Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backdrop): fix click events from content to close modal unexpectedly #265

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Conversation

unix
Copy link
Member

@unix unix commented Jun 9, 2020

PR Checklist

  • Fix linting errors
  • Label has been added

Change information

fixed #264

@unix unix added the type: bug Something isn't working label Jun 9, 2020
@unix unix self-assigned this Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #265 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         174      174           
  Lines        2189     2197    +8     
  Branches      517      519    +2     
=======================================
+ Hits         2188     2196    +8     
  Misses          1        1           
Impacted Files Coverage Δ
components/shared/backdrop.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44e751b...3be0e76. Read the comment docs.

@unix unix merged commit e58c0de into geist-org:master Jun 9, 2020
@unix unix deleted the backdrop branch June 9, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't close Modal onMouseUp
1 participant